expose NetcodeSocket #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benny-n
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Thanks for the PR!
Now that we expose NetcodeSocket, let's make sure it's hard to misuse by encapsulating the inner UdpSocket:
- pub struct NetcodeSocket(pub UdpSocket);
+ pub struct NetcodeSocket(UdpSocket);Other than that, LGTM.
I'll make sure to include this in v1.4.0!
|
I actually made a mistake with it I think, sorry I don't really know rust. I exposed it from the client module, not the socket module |
|
but I fixed that on the pr? |
|
just make sure you test it before you merge 😅 |
|
@benjamin-kirkbride No worries, that's what CI is for 😅 |
|
Thanks!!
…On Fri, Aug 16, 2024, 5:20 AM Benny Nazimov ***@***.***> wrote:
@benjamin-kirkbride <https://github.com/benjamin-kirkbride> No worries,
that's what CI is for 😅
I am also okay with merging it as is and making the change on my end.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZXWBUQ2S3DJNAOHCKJEL3ZRW767AVCNFSM6AAAAABMQQ5PKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGE2TENBRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10